opt(operator-v2): Resolve BR todos #6086
Conversation
|
/run-pull-e2e-kind-v2 |
| // TikvGCLifeTime is to specify the safe gc life time for backup. | ||
| // The time limit during which data is retained for each GC, in the format of Go Duration. | ||
| // When a GC happens, the current time minus this value is the safe point. | ||
| TikvGCLifeTime *string `json:"tikvGCLifeTime,omitempty"` |
There was a problem hiding this comment.
TikvGCLifeTime is only used when using dumpling mode as pseudo backup and only is required for tikv < v4.0.8.
| // TikvGCLifeTime is to specify the safe gc life time for restore. | ||
| // The time limit during which data is retained for each GC, in the format of Go Duration. | ||
| // When a GC happens, the current time minus this value is the safe point. | ||
| TikvGCLifeTime *string `json:"tikvGCLifeTime,omitempty"` |
| @@ -90,7 +90,6 @@ const ( | |||
| DirPathClusterTLSPD = "/var/lib/pd-tls" | |||
| DirPathClusterTLSTiKV = "/var/lib/tikv-tls" | |||
| DirPathClusterTLSTiDB = "/var/lib/tidb-tls" | |||
| DirPathTiDBClientTLS = "/var/lib/tidb-client-tls" // FIXME(ideascf): do we need this? | |||
There was a problem hiding this comment.
We don't need do tidb SQL client TLS
| // PDAddress is the address of the PD, for example: db-pd.tidb12345:2379 | ||
| PDAddress string |
There was a problem hiding this comment.
Since we can configure PD port for pd groups, so we need pass the PD address (with the port) to the backup-manager.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6086 +/- ##
==============================================
- Coverage 54.88% 54.61% -0.27%
==============================================
Files 221 223 +2
Lines 15135 15284 +149
==============================================
+ Hits 8307 8348 +41
- Misses 6828 6936 +108
Flags with carried forward coverage won't be shown. Click here to find out more. |
| } | ||
|
|
||
| // nolint: gocyclo | ||
| func (bm *Manager) performBackup(ctx context.Context, backup *v1alpha1.Backup, db *sql.DB) error { |
There was a problem hiding this comment.
Backup.spec.from is deprecated and only used for old versions of tikv and not supported for tikv >v6.5.1
|
/run-pull-e2e-kind-v2 |
| ) | ||
|
|
||
| // set tikv gc life time to prevent gc when backing up data | ||
| if db != nil { |
| @@ -269,33 +170,6 @@ func (bm *Manager) performBackup(ctx context.Context, backup *v1alpha1.Backup, d | |||
|
|
|||
| // run br binary to do the real job | |||
| backupErr := bm.backupData(ctx, backup) | |||
|
|
|||
| if db != nil && oldTikvGCTimeDuration < tikvGCTimeDuration { | |||
| @@ -50,6 +50,8 @@ type Options struct { | |||
| TargetAZ string | |||
| // UseFSR to indicate if use FSR for TiKV data volumes during EBS snapshot restore | |||
| UseFSR bool | |||
| // PDAddress is the address of the PD, for example: db-pd.tidb12345:2379 | |||
| PDAddress string | |||
| // if it's gone just return | ||
| task.IfBreak(common.CondJobHasBeenDeleted(state)), | ||
|
|
There was a problem hiding this comment.
We have to remove finalizer before we break the runner.
|
/run-pull-e2e-kind-v2 |
|
@ideascf: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-pull-e2e-kind-v2 |
|
/run-pull-e2e-kind-v2 |
1 similar comment
|
/run-pull-e2e-kind-v2 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgksgf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.